Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the message given to the player when using the light switch. #5795

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

Skas8825
Copy link
Contributor

@Skas8825 Skas8825 commented Dec 6, 2024

Checklist

Required

Purpose of change

When using the light switch the iexamine::toggle_lights was giving the wrong message to the player ("You switched off the lights." when turning them on and viceversa), turn out it was because the function was changing the state of the switch before retrieving it's message.

Describe the solution

Simply moving the line displaying the message to before changing the furnitures.

Describe alternatives you've considered

Retrieving and storing the message in a variable so the message still get executed in the end of the function, however this is kinda going back on a scarf review in #5626 (comment)_

@github-actions github-actions bot added the src changes related to source code. label Dec 6, 2024
@scarf005 scarf005 merged commit c4111a0 into cataclysmbnteam:main Dec 6, 2024
12 checks passed
@Skas8825 Skas8825 deleted the fix-switches-message branch December 22, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants